Increased azure repository network timeout to 30 minutes #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the ideal solution would be to make --timeout a CLI option, and set the default there to 30. Then all the implementations would accept the timeout as a parameter instead of having the defaults built-in. Although, I am happy to accept this as-is if you don't plan to work on it further. |
Author
|
Agreed, just wanted a quick fix for now. Happy to keep working in my own fork for the CLI argument. Could this be merged in the meantime, and then I'll create a new pull request once I've got an implementation for the new argument? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriden the default BlobClient options to change the network timeout from 100 seconds to 30 minutes.
should fix #377