Update doesn't excecute, because logfile rotation fails #674
Description
OS
Windows 11 24H2
Programming Language
C# with dotnet 8.0
VPK Version
0.0.1251
Library Version
0.0.1251
What happened?
As discussed here https://discord.com/channels/767856501477343282/1379404023698030644, it looks like there is a bug in the filerotate crate.
In the current constelation, the Update.exe won't finish the update and the app won't start after an update.
After deleting or renaming the Velopack.log file, everything works fine again.
Relevant log output
[lib-csharp:27236] [11:36:45] [Debug] [11:36:45] [INFO] Output File: Some("C:\\<LocalAppData>\\<AppName>\\packages\\VelopackTemp\\temp.3")
[lib-csharp:27236] [11:36:45] [Debug] [11:36:45] [INFO] Loading Dictionary (Size: 289064)
[lib-csharp:27236] [11:36:45] [Error] [11:36:45] [ERROR] thread 'main' panicked at 'assertion failed: !new_path.exists()': C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\file-rotate-0.8.0\src/lib.rs:554
[lib-csharp:27236] [11:37:15] [Warning] Unable to apply delta updates, falling back to full update.
System.TimeoutException: zstd patch process timed out (30s).
at Velopack.Compression.DeltaUpdateExe.ApplyZstdPatch(String baseFile, String patchFile, String outputFile)
at Velopack.Compression.DeltaPackage.applyDiffToFile(String deltaPath, String relativeFilePath, String workingDirectory)
at Velopack.Compression.DeltaPackage.ApplyDeltaPackageFast(String workingPath, String deltaPackageZip, Action`1 progress)
at Velopack.UpdateManager.DownloadAndApplyDeltaUpdates(String extractedBasePackage, UpdateInfo updates, Action`1 progress, CancellationToken cancelToken)
at Velopack.UpdateManager.DownloadUpdatesAsync(UpdateInfo updates, Action`1 progress, Boolean ignoreDeltas, CancellationToken cancelToken)
[lib-csharp:27236] [11:37:15] [Information] Downloading full release (AppName-0.9.20-full.nupkg)