-
-
Notifications
You must be signed in to change notification settings - Fork 104
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
OS
Mac OS Sequoia 15.4.1 (24E263)
Programming Language
dotnet 9.0
VPK Version
vpk 0.0.1251
Library Version
Nuget v.0.0.1251
What happened?
When an exception happens during progress callback (updateManager.DownloadUpdatesAsync(..., () => { /* exception happens here */ })), it gets caught by this global catch:
https://github.com/velopack/velopack/blob/develop/src/lib-csharp/Sources/HttpClientFileDownloader.cs#L29
(i agree on your comment btw ;))
Unfortunately this was very hard to debug, since the second "lowercase request" fired a 404 on azure storage.
A more specific catch (e.g. catching HttpRequestException - see EnsureSuccessStatusCode API doc) may also work here and would lead to a bit less confusing error.
Thanks for this great library!
Relevant log output
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working