Merged
Conversation
v1.7.7 v1.7.7 - event-emmiter code linting - NPM and Atmosphere dependencies update * `ostrio:cookies@2.1.2` * `fs-extra@2.0.0` * `file-type@4.1.0` - Fix double slash in generated file's URLs - Fix Cookies issue on IE, veliovgroup#327, thanks to @derwok - Fix false detection of unfinished uploads, veliovgroup#324, thanks to @derwok - Closing veliovgroup#316 with updated docs, thanks to @macrozone - Update Google Storage Integration docs, thanks to @jeremywrnr - [Security] Session Cookie live now limited to current session - [Security] Prevent file override, veliovgroup#312, thanks to @macrozone - [Security] Important notes about trust to mime-type and extension veliovgroup#313 veliovgroup#289 more in [this commit](veliovgroup@f039de8)
dr-dimitru
requested changes
Jan 22, 2017
Member
dr-dimitru
left a comment
There was a problem hiding this comment.
Line 565 - remove requires path as second argument
cookie.remove('x_mtok', '/') if cookie.has 'x_mtok'Could you please ad it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #327 (hopefully)