Skip to content

Doc update#255

Merged
dr-dimitru merged 5 commits intoveliovgroup:devfrom
elewis33:dev
Oct 12, 2016
Merged

Doc update#255
dr-dimitru merged 5 commits intoveliovgroup:devfrom
elewis33:dev

Conversation

@elewis33
Copy link
Copy Markdown
Contributor

@elewis33 elewis33 commented Oct 5, 2016

In constructor.md, add clarification under config.storagePath for handling of files stored at a relative path when in development mode. Let me know what you think.

@dr-dimitru
Copy link
Copy Markdown
Member

dr-dimitru commented Oct 5, 2016

Hi @elewis33

Thank you for PR.
I think we should mention the difference between path started with /
Also mention what this lib operates with FS, unlike Meteor's Assets class, which always relative to Meteor's root. I believe this was biggest complain of @yanickrochon .

Also feel free to update FAQ section in readme.md with this notice

@yanickrochon
Copy link
Copy Markdown

Thanks! This is much clearer this way, and will clarify future confusion (I probably only happen to be the first one stumbling on this and/or complaining about it).

@elewis33
Copy link
Copy Markdown
Contributor Author

elewis33 commented Oct 5, 2016

@yanickrochon, maybe it's just you and me that had the question? :)

@yanickrochon
Copy link
Copy Markdown

@elewis33 I doubt it. By experience, I know that many programmers don't ask questions or create issues and simply copy/paste snippets and move on. Meteor is also fairly new, and there aren't many users still.

@elewis33
Copy link
Copy Markdown
Contributor Author

elewis33 commented Oct 6, 2016

Any thoughts on these doc changes @dr-dimitru?

@dr-dimitru
Copy link
Copy Markdown
Member

@elewis33 looks good to me.
Planning big release this weekend. All PRs will be merged then. Thank you for contribution.

@dr-dimitru dr-dimitru merged commit 7afa0b6 into veliovgroup:dev Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants