Merged
Conversation
Contributor
Author
|
Actually, I didn't test |
| check selector, Match.OneOf Object, String, null | ||
| check options, Match.Optional Object | ||
|
|
||
| selector = {} unless arguments.length |
Member
There was a problem hiding this comment.
You're bringing back old behaviour unless arguments.length will be triggered on undefined, null, false all falsy values.
While find: (selector = {}) is equal to selector ?= {}, which will set selector only if it's null or undefined
Update: my bad, I was wrong, hold on for test from my end
Member
|
I've done tests. And it fails:
|
Member
|
so, different behaviour in: Will you fix it with one more PR? |
Contributor
Author
|
Thank you for your detailed investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #210 (the inconsistency of the behaviour of
findandfindOnebetweenMongo.CollectionandFilesCollection)