Skip to content

fix wrong variable name in example#220

Merged
dr-dimitru merged 8 commits intoveliovgroup:devfrom
noris666:patch-1
Sep 5, 2016
Merged

fix wrong variable name in example#220
dr-dimitru merged 8 commits intoveliovgroup:devfrom
noris666:patch-1

Conversation

@noris666
Copy link
Copy Markdown
Contributor

@noris666 noris666 commented Sep 5, 2016

  1. Make sure you're sending PR to dev branch
  2. Give a short description what you have changed/added and why

Thank you for contribuution, and do not forget to get rid of this default message

dr-dimitru and others added 8 commits August 24, 2016 21:25
v1.7.1
 - Compatibility with `Meteor@1.4.1.1`
 - Fix: veliovgroup#196 (use inline WebWorker if client has support, with fallback)
 - Implement: veliovgroup#192 (upload file as base64)
 - Closing: veliovgroup#182 with [React Integration Example](https://github.com/VeliovGroup/Meteor-Files/wiki/React-Example), thanks to [@vtocco](https://github.com/vtocco)
 - Minor DemoApp update
Docs update
 - CFS -> Meteor-Files migration guide
 - React example
v1.7.2
 - Fix veliovgroup#207 
 - Fix availability of `this.userId` in `onBeforeUpload` hook
 - `this.userId` now always `null` if user not logged in, previously
sometimes it might be `undefined`
 - Implement veliovgroup#208 : Documented as `onInitiateUpload` in [Constructor](https://github.com/VeliovGroup/Meteor-Files/wiki/Constructor)
 - Fix mime-type in base64 uploads, thanks to @FinnFrotscher
v1.7.3
 - Fix veliovgroup#214 - Chunks was incorrectly generated, without padding - Fixed
 - Fix veliovgroup#212 - Set token cookie after user logged-in
 - Fix veliovgroup#210 - Now `FilesCollection#findOne()` has same behaviour, as `MongoCollection#findOne()`
 - `protected` hook optimisation
@dr-dimitru
Copy link
Copy Markdown
Member

See №1 from your message, please

@noris666 noris666 changed the base branch from master to dev September 5, 2016 18:40
@noris666
Copy link
Copy Markdown
Contributor Author

noris666 commented Sep 5, 2016

@dr-dimitru done.

@dr-dimitru dr-dimitru merged commit 1622e5c into veliovgroup:dev Sep 5, 2016
@dr-dimitru
Copy link
Copy Markdown
Member

@noris666 looks like this variable has long and complicated history: https://github.com/VeliovGroup/Meteor-Files/wiki/Create-and-Manage-Subversions/_history# XD

@noris666
Copy link
Copy Markdown
Contributor Author

noris666 commented Sep 5, 2016

:-D

@dr-dimitru
Copy link
Copy Markdown
Member

@noris666 thank you for contribution and your accuracy 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants