fix to get extension if link has query params after extension#185
Merged
dr-dimitru merged 1 commit intoveliovgroup:masterfrom Aug 14, 2016
salmanhasni:ext-fix
Merged
fix to get extension if link has query params after extension#185dr-dimitru merged 1 commit intoveliovgroup:masterfrom salmanhasni:ext-fix
dr-dimitru merged 1 commit intoveliovgroup:masterfrom
salmanhasni:ext-fix
Conversation
Contributor
Author
|
@dr-dimitru Can you please review it |
Member
|
Could you please send this PR to |
Contributor
Author
|
@dr-dimitru Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Previously getExt return the object with extension having any string after "."
Now
getExt will return ext in between '.' and '?' (so it trim the query params including question mark)
Blocking Cause
On Windows Special characters (which are found in query params '?' '&' ) are not allowed in file or folder naming convention therefore not allowing file stream to write.
Tested On
Windows 10
This PR is raise again this issue