Add multiarch container builds#518
Merged
LandonTClipp merged 1 commit intovektra:masterfrom Nov 15, 2022
arbourd:add-multiarch-builds
Merged
Add multiarch container builds#518LandonTClipp merged 1 commit intovektra:masterfrom arbourd:add-multiarch-builds
LandonTClipp merged 1 commit intovektra:masterfrom
arbourd:add-multiarch-builds
Conversation
Uses docker manifests to build 2 seperate images, one per arch, pushes them both, and then combines them with a common title, as per the docs: https://goreleaser.com/customization/docker_manifest/
Codecov ReportBase: 72.42% // Head: 72.42% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 6 6
Lines 1262 1262
=======================================
Hits 914 914
Misses 304 304
Partials 44 44 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses docker manifests to build 2 separate images, one per arch, pushes them both, and then combines them with common tags, as per the docs: https://goreleaser.com/customization/docker_manifest/
Fixes #440
Type of change
Version of Golang used when building/testing:
How Has This Been Tested?
Ran locally and built the images with GoReleaser.
The manifests command doesn't run unless the release actually happens.
Checklist