Skip to content

update to go 1.19#515

Merged
LandonTClipp merged 1 commit intovektra:masterfrom
m9tdev:master
Nov 15, 2022
Merged

update to go 1.19#515
LandonTClipp merged 1 commit intovektra:masterfrom
m9tdev:master

Conversation

@m9tdev
Copy link
Copy Markdown
Contributor

@m9tdev m9tdev commented Oct 31, 2022

Description

I updated the go version from 1.18 to 1.19. This resulted in broken tests, which I've also fixed. The generated code seems to differ a bit with what is was on 1.18. Not sure why that is, but according to #502 it seems that more people have this issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.19

How Has This Been Tested?

go test ./...

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp
Copy link
Copy Markdown
Member

Excellent thanks for the PR, I'll get this merged if the tests pass.

@LandonTClipp LandonTClipp merged commit a55c02d into vektra:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing on current master

2 participants