feat: goimports configuration options#1138
Conversation
bc0ef83 to
dc7ca2f
Compare
LandonTClipp
left a comment
There was a problem hiding this comment.
Looks great, let's just extend this a bit more.
0d6c326 to
db3355e
Compare
LandonTClipp
left a comment
There was a problem hiding this comment.
Just one change, we can delete one of the tests. Once that's done, let's get it merged!
bdd9486 to
5882b70
Compare
5882b70 to
4dfe781
Compare
LandonTClipp
left a comment
There was a problem hiding this comment.
This is great! I'm going to give it one last manual verification before merging.
|
Actually, it looks like the tests are revealing backwards-incompatible behavior: https://github.com/vektra/mockery/pull/1138/changes#diff-dd1c701f26e4b66f2c1c1b312fd78581f706770353861da4095b1fbf740c47deL490-L494 These are the values mockery provided by default so we should keep |
|
Updated. Which test is failing though? I only see these which don't look related? |
|
The test was showing that some mock generation was producing a different result than what was committed (git diff). You fixed the issue but now there is a test that needs its default value updated. Then, we should be good to go. |
08408ef to
533f37c
Compare
|
Wonderful, thank you @rfwatson for the contribution! |
Description
Add goimports local-prefix configuration. Fixes #1098.
Type of change
Version of Go used when building/testing:
How Has This Been Tested?
Mostly manual testing. It seems that testing the actual formatter call could be a bit tricky, happy to take a look at adding some if you think it's worth it though.
Checklist