Fix breaking change with InterfaceDirRelative#1135
Merged
LandonTClipp merged 2 commits intovektra:v3from Jan 16, 2026
Merged
Conversation
b5d0d56 to
4d1684b
Compare
An attempt to fix a breaking change between v2 and v3 with InterfaceDirRelative inadvertently caused another breaking change with existing v3 users. Tests have been added that assert both cases are sane and work properly. Related to vektra#1133.
4d1684b to
5f1374c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix a breaking change between v2 and v3 with InterfaceDirRelative inadvertently caused another breaking change with existing v3 users. Tests have been added that assert both cases are sane and work properly.
Related to #1133.