fix: improve expressions#4147
Conversation
bbc33d2 to
e59a8bd
Compare
|
Basemap test was erroring on the first go for node 21, but it passed after 2 retries. Do you think we should update the package-lock.json as well (since that's what should ensure consistent installs when cloning/running locally), or just updating the package.json are enough? cc @domoritz |
We can make those changes on the maintenance branch rather than this pull request. |
Thanks @domoritz , I wasn't sure if we need to update package-lock.json right away to get the unit tests to use the latest code on branch rather than downloading from NPM. If the current diff is ready for use, then I'll leave it to you and Lukas re: releasing these updates to the non-ESM version of Vega. |
|
Before making a release, we need to check the scripts to delete anything that would override release artifacts like the schema or website. But happy to merge this pr as is. |
|
Fair enough. FWIW from what I can see the docs site deploy only runs on the https://github.com/vega/vega/actions/runs/18161260314 Let's merge this PR then if we're all set from the Kibana side. |
cb3eec8
into
vega:long-term-support/vega-5
|
We should delete anything that may release. |
## Motivation - Prepare 5.33.1 release - Followup on comment to update the lockfile: #4147 (comment) ## Changes - Ran `yarn install` in the repository root using node `20.15.1` and yarn `1.22.19`
No description provided.