Skip to content

fix: improve expressions#4147

Merged
hydrosquall merged 2 commits intovega:long-term-support/vega-5from
markov00:improve-expressions
Oct 8, 2025
Merged

fix: improve expressions#4147
hydrosquall merged 2 commits intovega:long-term-support/vega-5from
markov00:improve-expressions

Conversation

@markov00
Copy link

@markov00 markov00 commented Oct 1, 2025

No description provided.

@markov00 markov00 requested a review from a team as a code owner October 1, 2025 10:13
@markov00 markov00 marked this pull request as draft October 1, 2025 11:23
@markov00 markov00 force-pushed the improve-expressions branch from bbc33d2 to e59a8bd Compare October 1, 2025 17:18
@markov00 markov00 marked this pull request as ready for review October 1, 2025 20:11
@hydrosquall
Copy link
Member

Basemap test was erroring on the first go for node 21, but it passed after 2 retries.

Do you think we should update the package-lock.json as well (since that's what should ensure consistent installs when cloning/running locally), or just updating the package.json are enough? cc @domoritz

@domoritz
Copy link
Member

domoritz commented Oct 3, 2025

  • package-lock.json should be updated. If we run npm ci it should error when the locale is not up to date
  • remove any kind of deployment scripts for the website so that we don't accidentally override the current version. We also should not push schema updates.

We can make those changes on the maintenance branch rather than this pull request.

@hydrosquall
Copy link
Member

We can make those changes on the maintenance branch

Thanks @domoritz , I wasn't sure if we need to update package-lock.json right away to get the unit tests to use the latest code on branch rather than downloading from NPM. If the current diff is ready for use, then I'll leave it to you and Lukas re: releasing these updates to the non-ESM version of Vega.

@domoritz
Copy link
Member

domoritz commented Oct 6, 2025

Before making a release, we need to check the scripts to delete anything that would override release artifacts like the schema or website.

But happy to merge this pr as is.

@hydrosquall
Copy link
Member

Fair enough. FWIW from what I can see the docs site deploy only runs on the main branch, so merges to this long-term-support branch should be unaffected. I'm less clear on where the "publish new schema" script would live.

https://github.com/vega/vega/actions/runs/18161260314

Let's merge this PR then if we're all set from the Kibana side.

@hydrosquall hydrosquall merged commit cb3eec8 into vega:long-term-support/vega-5 Oct 8, 2025
7 of 16 checks passed
@domoritz
Copy link
Member

domoritz commented Oct 8, 2025

We should delete anything that may release.

hydrosquall added a commit that referenced this pull request Oct 23, 2025
## Motivation

- Prepare 5.33.1 release
- Followup on comment to update the lockfile:
#4147 (comment)

## Changes

- Ran `yarn install` in the repository root using node `20.15.1` and
yarn `1.22.19`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants