Conversation
They don't really help since we don't ship the sources in the package anyway. If you want sourcemaps, use ESM.
There was a problem hiding this comment.
I think a second impact is this will speed up the build times too! I don't have metrics before/after metrics on what this looked like before (perhaps this is something we could start tracking in github actions).
From past work, I've seen sourcemaps generation may add noticeable overhead to compile time, and that we might want to save those for dev rather than production mode.
Disk savings
It looks like we'll save close to 6 MB by not shipping sourcemaps per runpkg - nice!
Unfortunately the install footprint still seems like it's over 20 MB, but this might be something we get to address by addressing the maps on the various sub dependencies of vega
Meta
Node.js test is failing on vega-interpreter, but I think it's unrelated to this change, so we can investigate it separately.
There is a flaky test. I just kept rerunning and then tests pass. Yes, would be lovely to investigate. |
They don't really help since we don't ship the sources in the package anyway. If you want sourcemaps, use ESM.
This change should make our packages smaller. See https://packagephobia.com/result?p=vega