Skip to content

Verify unfetched roomkey senders#913

Merged
bwindels merged 15 commits intomasterfrom
bwindels/verify-unfetched-roomkey-senders
Nov 4, 2022
Merged

Verify unfetched roomkey senders#913
bwindels merged 15 commits intomasterfrom
bwindels/verify-unfetched-roomkey-senders

Conversation

@bwindels
Copy link
Copy Markdown
Contributor

No description provided.

to differentiate with method to come for verifying senders that need to
be fetched still, and also allow reuse of verification logic by said new
method.

Also get rid of roomTracked flag in DecryptionResult as once we fetch
unknown senders (in commit to come), we should now always have a device,
unless the device isn't known on the server,
in which case we should shout.
remove needsAfterSyncCompleted step as well, performance difference
should be neglible
@bwindels
Copy link
Copy Markdown
Contributor Author

Should be somewhat complete, but needs testing

@bwindels
Copy link
Copy Markdown
Contributor Author

bwindels commented Nov 3, 2022

after testing:

  • sync afterSyncCompleted gets triggered but doesn't fetch the keys
  • updating the UI does not work

@bwindels bwindels marked this pull request as ready for review November 3, 2022 16:39
@bwindels bwindels merged commit cc70d44 into master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant