Skip to content

Circuit breaker playground#38

Merged
vearutop merged 2 commits intomasterfrom
cb-demo
Nov 11, 2024
Merged

Circuit breaker playground#38
vearutop merged 2 commits intomasterfrom
cb-demo

Conversation

@vearutop
Copy link
Copy Markdown
Owner

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2024

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 18 (+2) 2261 (+220) 1739 (+148) 92 (+27) 430 (+45) 295 (+18) 59K (+6.2K)
Go (test) 5 268 224 0 44 5 6.1K (+8B)
Markdown 2 (+1) 248 (+5) 197 (+3) 0 51 (+2) 0 9.4K (+177B)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2024

Go API Changes

# github.com/vearutop/plt/fasthttp
## incompatible changes
NewJobProducer: changed from func(github.com/vearutop/plt/nethttp.Flags) (*JobProducer, error) to func(github.com/vearutop/plt/nethttp.Flags, github.com/vearutop/plt/loadgen.Flags, ...func(lf *github.com/vearutop/plt/loadgen.Flags, f *github.com/vearutop/plt/nethttp.Flags, j github.com/vearutop/plt/loadgen.JobProducer)) (*JobProducer, error)

# github.com/vearutop/plt/loadgen
## incompatible changes
Flags: old is comparable, new is not
## compatible changes
Flags.KeyPressed: added
Flags.PrepareLoadLimitsWidget: added

# github.com/vearutop/plt/nethttp
## incompatible changes
NewJobProducer: changed from func(Flags, github.com/vearutop/plt/loadgen.Flags) (*JobProducer, error) to func(Flags, github.com/vearutop/plt/loadgen.Flags, ...func(lf *github.com/vearutop/plt/loadgen.Flags, f *Flags, j github.com/vearutop/plt/loadgen.JobProducer)) (*JobProducer, error)
## compatible changes
JobProducer.PrepareRoundTripper: added

# summary
Inferred base version: v0.3.12
Suggested version: v0.4.0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2024

Unit Test Coverage

total: (statements) 42.7%
changed lines: (statements) 45.0%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 45.0%
curl/cmd.go 0.0%
curl/cmd.go:199 run 0.0%
fasthttp/job.go 80.0%
fasthttp/job.go:77 NewJobProducer 71.4%
loadgen/app.go 0.0%
loadgen/app.go:9 Register 0.0%
loadgen/run.go 0.0%
loadgen/run.go:342 startLiveUIPoller 0.0%
loadgen/run.go:366 runLiveUI 0.0%
nethttp/job.go 85.2%
nethttp/job.go:176 NewJobProducer 91.3%
nethttp/job.go:98 makeTransport 72.7%
_examples/circuit-breaker-playground/main.go no coverage
_examples/circuit-breaker-playground/middleware.go no coverage
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 42.6% 42.7% (+0.1%)
fasthttp/job.go NewJobProducer 87.0% 84.0% (-3.0%)
nethttp/job.go NewJobProducer 91.3% 88.0% (-3.3%)
nethttp/job.go makeTransport 50.0% 62.5% (+12.5%)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2024

Benchmark Result

Benchmark diff with base branch
name               old time/op    new time/op    delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    13.4µs ± 2%    13.8µs ± 2%  +3.18%  (p=0.030 n=5+6)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    1.00ms ± 0%    1.00ms ± 0%    ~     (p=1.000 n=6+6)

name               old alloc/op   new alloc/op   delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    1.89kB ± 0%    1.91kB ± 0%  +0.91%  (p=0.008 n=5+5)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    6.53kB ± 0%    6.53kB ± 0%    ~     (p=0.896 n=6+5)

name               old allocs/op  new allocs/op  delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4      25.0 ± 0%      25.0 ± 0%    ~     (all equal)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4      92.0 ± 0%      91.5 ± 1%    ~     (p=0.121 n=5+6)
Benchmark result
name               time/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4  13.8µs ± 2%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4  1.00ms ± 0%

name               alloc/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4  1.91kB ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4  6.53kB ± 0%

name               allocs/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    25.0 ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    91.5 ± 1%

@vearutop vearutop merged commit 5845680 into master Nov 11, 2024
@vearutop vearutop deleted the cb-demo branch November 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant