Skip to content

Increase concurrency hard limit for fasthttp, update deps#33

Merged
vearutop merged 2 commits intomasterfrom
increase-fasthttp-concurrency
Jul 3, 2023
Merged

Increase concurrency hard limit for fasthttp, update deps#33
vearutop merged 2 commits intomasterfrom
increase-fasthttp-concurrency

Conversation

@vearutop
Copy link
Copy Markdown
Owner

@vearutop vearutop commented Jul 3, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2023

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 17 2026 (+1) 1583 (+1) 65 378 271 52.5K (+34B)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2023 •
edited
Loading

Go API Changes

# summary
Inferred base version: v0.3.9
Suggested version: v0.3.10

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2023

Unit Test Coverage

total: (statements) 54.9%
changed lines: (statements) 100.0%

Coverage of changed lines
File Function Coverage
Total 100.0%
fasthttp/job.go 100.0%
fasthttp/job.go:76 NewJobProducer 100.0%
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 54.8% 54.9% (+0.1%)
github.com/vearutop/plt/fasthttp/job.go NewJobProducer 86.4% 87.0% (+0.6%)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2023

Benchmark Result

Benchmark diff with base branch 
name               old time/op    new time/op    delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    21.0µs ± 2%    21.0µs ± 1%   ~     (p=0.792 n=6+5)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    1.00ms ± 0%    1.01ms ± 0%   ~     (p=0.065 n=6+6)

name               old alloc/op   new alloc/op   delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    1.82kB ± 0%    1.82kB ± 0%   ~     (p=0.136 n=6+6)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    5.76kB ± 0%    5.76kB ± 0%   ~     (p=1.000 n=5+6)

name               old allocs/op  new allocs/op  delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2      25.0 ± 0%      25.0 ± 0%   ~     (all equal)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2      85.0 ± 0%      85.0 ± 0%   ~     (all equal)
Benchmark result 
name               time/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2  21.0µs ± 1%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2  1.01ms ± 0%

name               alloc/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2  1.82kB ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2  5.76kB ± 0%

name               allocs/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    25.0 ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    85.0 ± 0%

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (4b75bf4) 47.91% compared to head (d279b3e) 48.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   47.91%   48.00%   +0.08%     
==========================================
  Files           8        8              
  Lines         599      600       +1     
==========================================
+ Hits          287      288       +1     
  Misses        270      270              
  Partials       42       42
Flag Coverage Δ
unittests 48.00% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fasthttp/job.go 81.25% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vearutop vearutop merged commit c887386 into master Jul 3, 2023
@vearutop vearutop deleted the increase-fasthttp-concurrency branch July 3, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vearutop @codecov-commenter