Skip to content

Enable http3 for go1.20+, update deps#32

Merged
vearutop merged 13 commits intomasterfrom
upd-go1.20
Jun 30, 2023
Merged

Enable http3 for go1.20+, update deps#32
vearutop merged 13 commits intomasterfrom
upd-go1.20

Conversation

@vearutop
Copy link
Copy Markdown
Owner

@vearutop vearutop commented Jun 30, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2023 •
edited
Loading

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 17 (+1) 2025 (+12) 1582 (+6) 65 (+2) 378 (+4) 271 52.5K (+202B)
Makefile 1 44 32 4 8 2 1.3K (+1B)
Markdown 1 243 194 0 49 0 9.3K (+94B)
YAML 8 593 (+9) 497 43 53 (+9) 0 19.9K (+346B)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2023 •
edited
Loading

Go API Changes

# github.com/vearutop/plt/nethttp
## incompatible changes
HTTP3Available: value changed from false to true

# summary
Inferred base version: v0.3.8
Suggested version: v0.4.0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2023 •
edited
Loading

Benchmark Result

Benchmark diff with base branch 
name               old time/op    new time/op    delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    19.0µs ±10%    18.7µs ± 2%   ~     (p=0.931 n=6+5)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    1.00ms ± 0%    1.00ms ± 0%   ~     (p=0.240 n=6+6)

name               old alloc/op   new alloc/op   delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    1.82kB ± 0%    1.82kB ± 0%   ~     (p=0.530 n=6+6)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    5.75kB ± 0%    5.76kB ± 0%   ~     (p=0.264 n=6+6)

name               old allocs/op  new allocs/op  delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2      25.0 ± 0%      25.0 ± 0%   ~     (all equal)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2      85.0 ± 0%      85.0 ± 0%   ~     (all equal)
Benchmark result 
name               time/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2  18.7µs ± 2%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2  1.00ms ± 0%

name               alloc/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2  1.82kB ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2  5.76kB ± 0%

name               allocs/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-2    25.0 ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-2    85.0 ± 0%

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2023

Unit Test Coverage

total: (statements) 54.8%

Coverage of changed lines

No changes in testable statements.

Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 54.8% 54.8% (0.0%)
github.com/vearutop/plt/nethttp/http3.go makeTransport3 no function 0.0%
github.com/vearutop/plt/nethttp/http3_go1.20.go makeTransport3 0.0% no function

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 30, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (d69bde0) 47.91% compared to head (14f43e2) 47.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   47.91%   47.91%           
=======================================
  Files           8        8           
  Lines         599      599           
=======================================
  Hits          287      287           
  Misses        270      270           
  Partials       42       42
Flag Coverage Δ
unittests 47.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nethttp/http3.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vearutop vearutop merged commit 4b75bf4 into master Jun 30, 2023
@vearutop vearutop deleted the upd-go1.20 branch June 30, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vearutop @codecov-commenter