Skip to content

Bump Catch2 to v3.7.1#686

Merged
elazarg merged 1 commit into
mainfrom
bump-catch2
Sep 24, 2024
Merged

Bump Catch2 to v3.7.1#686
elazarg merged 1 commit into
mainfrom
bump-catch2

Conversation

@elazarg

@elazarg elazarg commented Sep 24, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Upgraded the Catch2 library to version 3.7.1, ensuring improved functionality and performance for testing.

@elazarg
bump catch2 to v3.7.1
569d16e 
Signed-off-by: Elazar Gershuni <elazarg@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

The pull request updates the version of the Catch2 library in the CMakeLists.txt file. The version has been changed from v3.5.2 to v3.7.1 by modifying the Git tag used in the FetchContent_Declare directive. This change reflects an upgrade to a more recent version of the Catch2 testing framework.

Changes

File Change Summary
CMakeLists.txt Updated Git tag for Catch2 from 05e10dfccc28c7f973727c54f850237d07d5e10f (v3.5.2) to fa43b77429ba76c462b1898d6cd2f2d7a9416b14 (v3.7.1).

Sequence Diagram(s)

sequenceDiagram
    participant CMake as CMakeLists.txt
    participant Catch2 as Catch2 Library

    CMake->>Catch2: Fetch version v3.7.1
    Catch2-->>CMake: Provide updated library
Loading

Poem

In the garden of code, a change we see,
Catch2 hops along, now version three point seven one, whee!
With each little update, our tests will grow,
A leap for the project, a joyful flow.
So let’s cheer for the changes, both big and small,
For in the world of coding, we’re having a ball! 🐇✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 0a56b27 and 569d16e.

Files selected for processing (1)
  • CMakeLists.txt (1 hunks)
Additional comments not posted (2)
CMakeLists.txt (2)

Line range hint 1-186: Overall, the Catch2 update looks good.

The change to update Catch2 to v3.7.1 is isolated and doesn't require any additional modifications to the CMakeLists.txt file. This update should bring in the latest improvements and bug fixes from the Catch2 library.

Remember to test thoroughly after this update to ensure all existing functionality works as expected with the new Catch2 version.

10-10: LGTM! Catch2 updated to v3.7.1.

The Catch2 library has been successfully updated from v3.5.2 to v3.7.1. This is a good practice to keep dependencies up-to-date.

To ensure a smooth transition, please:

  1. Review the Catch2 changelog for any breaking changes or deprecations between v3.5.2 and v3.7.1.
  2. Run the full test suite to verify compatibility with the new version.

You can use the following command to check the Catch2 changelog:

This will help identify any potential issues that may arise from the update.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coveralls

coveralls commented Sep 24, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 90.409%. remained the same
when pulling 569d16e on bump-catch2
into 0a56b27 on main.

@elazarg elazarg merged commit 4ee1d77 into main Sep 24, 2024
@elazarg elazarg deleted the bump-catch2 branch September 24, 2024 12:26
@coderabbitai coderabbitai Bot mentioned this pull request Sep 30, 2024
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 1, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 6, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 25, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Oct 1, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Dec 30, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Feb 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elazarg @coveralls