Skip to content

Allow reversing condition to render a file#482

Merged
fpseverino merged 7 commits intovapor:mainfrom
fpseverino:file-boolean-condition
Jun 5, 2025
Merged

Allow reversing condition to render a file#482
fpseverino merged 7 commits intovapor:mainfrom
fpseverino:file-boolean-condition

Conversation

@fpseverino
Copy link
Copy Markdown
Member

@fpseverino fpseverino commented Jun 2, 2025

These changes are now available in 19.2.0

  • Check for a ! at the start of the if: condition to render a file, in which case it reverses the condition
  • Support shell completion scripts
  • Fix tests on Android

@fpseverino fpseverino requested review from MahdiBM and ptoffy June 2, 2025 17:09
@fpseverino fpseverino requested a review from 0xTim as a code owner June 2, 2025 17:09
@fpseverino fpseverino added the semver-minor Contains new APIs label Jun 2, 2025
@fpseverino fpseverino requested a review from gwynne as a code owner June 2, 2025 17:09
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 39.35%. Comparing base (dbe0d58) to head (d02ee0b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/VaporToolbox/TemplateRenderer.swift 0.00% 16 Missing ⚠️
Sources/VaporToolbox/New.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   40.53%   39.35%   -1.19%     
==========================================
  Files           7        7              
  Lines         634      648      +14     
==========================================
- Hits          257      255       -2     
- Misses        377      393      +16     
Files with missing lines Coverage Δ
Sources/VaporToolbox/Vapor.swift 71.05% <100.00%> (-2.29%) ⬇️
Sources/VaporToolbox/New.swift 0.00% <0.00%> (ø)
Sources/VaporToolbox/TemplateRenderer.swift 10.71% <0.00%> (-0.83%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fpseverino fpseverino merged commit ed8bca6 into vapor:main Jun 5, 2025
27 checks passed
@fpseverino fpseverino deleted the file-boolean-condition branch June 5, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-minor Contains new APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants