Skip to content

Use swift-subprocess and ConsoleKit v5#479

Merged
fpseverino merged 63 commits intovapor:mainfrom
fpseverino:subprocess
Nov 21, 2025
Merged

Use swift-subprocess and ConsoleKit v5#479
fpseverino merged 63 commits intovapor:mainfrom
fpseverino:subprocess

Conversation

@fpseverino
Copy link
Copy Markdown
Member

@fpseverino fpseverino commented Apr 29, 2025 •
edited
Loading

Resolves #474, resolves #461

Changes

  • Update to Swift 6.1
  • Remove all Foundation.Processes in favor of Subprocesses
  • Use ConsoleKit v5 for terminal I/O
  • Make the build.swift script an executable target
  • Enable manual (man) generation

Note

A change to the Homebrew Formula will be required to install the manual

MahdiBM
MahdiBM approved these changes Apr 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

@fpseverino fpseverino marked this pull request as ready for review April 29, 2025 15:19
@fpseverino fpseverino requested review from 0xTim and gwynne as code owners April 29, 2025 15:19
@fpseverino fpseverino marked this pull request as draft April 29, 2025 17:02
MahdiBM
MahdiBM requested changes Apr 29, 2025
View reviewed changes
@MahdiBM
Copy link
Copy Markdown
Contributor

MahdiBM commented Apr 29, 2025

<I do notice the PR is still in draft, just a bit excited for us to start using Subprocess>

fpseverino and others added 3 commits April 29, 2025 20:07
@fpseverino @MahdiBM
Update Sources/Build/Build.swift
09131f8 
Co-authored-by: Mahdi Bahrami <github@mahdibm.com>
@fpseverino @MahdiBM
Update Sources/Build/Build.swift
a4a0b0f 
Co-authored-by: Mahdi Bahrami <github@mahdibm.com>
@fpseverino @MahdiBM
Update Sources/Build/Build.swift
782bfba 
Co-authored-by: Mahdi Bahrami <github@mahdibm.com>
@fpseverino
Copy link
Copy Markdown
Member Author

fpseverino commented Apr 29, 2025

<I do notice the PR is still in draft, just a bit excited for us to start using Subprocess>

I'm excited too, but we can't really ship it at the moment because it doesn't have a tagged release yet.
I also have to solve a few problems due to the transition to the async world.

@MahdiBM
Copy link
Copy Markdown
Contributor

MahdiBM commented Apr 29, 2025

@fpseverino now worries, thank you :)

@fpseverino
Copy link
Copy Markdown
Member Author

fpseverino commented Apr 29, 2025

@MahdiBM thank you for the review!!

@fpseverino fpseverino changed the title Use swift-subprocess Use swift-subprocess and ConsoleKit v5 Jun 5, 2025
@fpseverino fpseverino mentioned this pull request Oct 9, 2025
Open
@fpseverino fpseverino marked this pull request as ready for review November 21, 2025 12:39
@fpseverino fpseverino requested a review from MahdiBM November 21, 2025 12:41
0xTim
0xTim approved these changes Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections on my part

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 18.07229% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.12%. Comparing base (3cb2f37) to head (fc576a4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/BuildToolbox/Build.swift 0.00% 52 Missing ⚠️
Sources/VaporToolbox/New.swift 0.00% 28 Missing ⚠️
Sources/VaporToolbox/TemplateRenderer.swift 0.00% 21 Missing ⚠️
Sources/VaporToolbox/Util/PrintUtilities.swift 0.00% 18 Missing ⚠️
Sources/VaporToolbox/Vapor.swift 63.82% 17 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3cb2f37) and HEAD (fc576a4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3cb2f37) HEAD (fc576a4)
6 5
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #479       +/-   ##
===========================================
- Coverage   40.00%   19.12%   -20.88%     
===========================================
  Files           7        6        -1     
  Lines         585      570       -15     
===========================================
- Hits          234      109      -125     
- Misses        351      461      +110
Files with missing lines Coverage Δ
Sources/VaporToolbox/Vapor.swift 67.04% <63.82%> (-3.97%) ⬇️
Sources/VaporToolbox/Util/PrintUtilities.swift 3.33% <0.00%> (-95.57%) ⬇️
Sources/VaporToolbox/TemplateRenderer.swift 13.74% <0.00%> (+2.12%) ⬆️
Sources/VaporToolbox/New.swift 0.00% <0.00%> (ø)
Sources/BuildToolbox/Build.swift 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fpseverino fpseverino added the semver-major Breaking changes. label Nov 21, 2025
@fpseverino fpseverino merged commit 8fdd9a0 into vapor:main Nov 21, 2025
29 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

@MahdiBM MahdiBM Awaiting requested review from MahdiBM

Assignees

No one assigned

Labels

semver-major Breaking changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate async Process Stuck in cloning template when vapor new a project in a Linux Docker container

3 participants

@fpseverino @MahdiBM @0xTim