Improve Makefile#478
Merged
fpseverino merged 22 commits intovapor:mainfrom Mar 28, 2025
fpseverino:print
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 40.50% 40.53% +0.02%
==========================================
Files 7 7
Lines 632 634 +2
==========================================
+ Hits 256 257 +1
- Misses 376 377 +1
🚀 New features to boost your workflow:
|
0xTim
approved these changes
Mar 27, 2025
Closed
0xTim
approved these changes
Mar 27, 2025
|
|
||
| task.terminationHandler = { process in | ||
| guard process.terminationStatus == 0 else { | ||
| print("build.swift: Error in backgroundShell (\(args))") |
Member
There was a problem hiding this comment.
This will probably be useful for anyone else building on different systems 👍
CrisCard0so
reviewed
Mar 27, 2025
| @@ -1,26 +1,21 @@ | |||
| DEST := /usr/local/bin/vapor | |||
| DEST ?= /usr/local/bin/vapor | |||
Member
Author
There was a problem hiding this comment.
Here it's the full path of the executable though, not just its directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 19.1.1
SUDOflag to Makefile--versionupdate-homebrewworkflowCloses #393, closes #413, closes #469, closes #342