Add support for JSON manifest files#477
Merged
fpseverino merged 4 commits intovapor:mainfrom Mar 27, 2025
fpseverino:json
Merged
Add support for JSON manifest files#477fpseverino merged 4 commits intovapor:mainfrom fpseverino:json
fpseverino merged 4 commits intovapor:mainfrom
fpseverino:json
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 40.35% 40.50% +0.15%
==========================================
Files 7 7
Lines 627 632 +5
==========================================
+ Hits 253 256 +3
- Misses 374 376 +2
🚀 New features to boost your workflow:
|
0xTim
reviewed
Mar 21, 2025
| @Test("Template Manifest") | ||
| func templateManifest() throws { | ||
| let manifestPath = URL(filePath: #filePath).deletingLastPathComponent().appending(path: "manifest.yml") | ||
| @Test("Template Manifest", arguments: ["manifest.yml", "manifest.json"]) |
README.md
Outdated
| If you are creating a custom template and want to dynamically generate the project depending on some variable given to the Toolbox, you have to add to the template a manifest file. | ||
|
|
||
| By default, the Toolbox looks for a file named `manifest.yml` in the root of the template, but you can specify a different file path with the `--manifest` flag. | ||
| By default, the Toolbox looks for a YAML file named `manifest.yml` in the root of the template, but you can specify a different file path with the `--manifest` flag. You can also write the manifest file in JSON format, specifying the correct file extension in the `--manifest` flag. |
Member
There was a problem hiding this comment.
Can we support manifest.json by default as well? So flow would be:
- Use
--manifestflag if provided - Fallback to
manifest.ymlif no flag - Fallback to
manifest.jsonif no yaml file - Error
0xTim
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 19.1.0
While keeping YAML files as the default, add support for parsing manifest files in JSON format