Conversation
Member
|
We want to keep the toolbox compatible with 5.5 for users on old versions of macOS. I recently had to do a PR to restore that compatibility. There's no need to bump that minimum (though bumping the integration tests is a good idea). |
0xTim
commented
May 13, 2024
Member
Author
|
Done, no need for a release then |
Member
|
@0xTim Fixing the CI requires adding the same "we now need an available database server for the template's tests" logic to the toolbox CI that I added to the template's CI (see https://github.com/vapor/template/blob/main/.github/workflows/test-template.yml#L51-L118) |
Member
Author
|
How the hell has this ever passed in the past |
Member
|
Those tests didn't previously exist so there was nothing to fail. |
Member
Author
|
Ohh right, we ran tests but didn't do anything in them. Makes sense |
gwynne
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the integration tests to 5.10 to match the template and the toolbox minimum Swift version to 5.8 to match Vapor