Add Benchmarks for ConsoleLogger#222
Merged
fpseverino merged 4 commits intovapor:consolekit-5from Oct 12, 2025
fpseverino:benchmarks
Merged
Add Benchmarks for ConsoleLogger#222fpseverino merged 4 commits intovapor:consolekit-5from fpseverino:benchmarks
fpseverino merged 4 commits intovapor:consolekit-5from
fpseverino:benchmarks
Conversation
MahdiBM
requested changes
Oct 11, 2025
Benchmarks/ConsoleLoggerBenchmarks/ConsoleLoggerBenchmarks.swift
Outdated
Show resolved
Hide resolved
MahdiBM
requested changes
Oct 11, 2025
MahdiBM
approved these changes
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I'd add the benchmarks before removing
ConsoleLogger's dependency onConsoleKitto see if we gain anything.