Skip to content

Fix activity indicator bug and update API#215

Merged
fpseverino merged 10 commits intovapor:consolekit-5from
fpseverino:update
Aug 23, 2025
Merged

Fix activity indicator bug and update API#215
fpseverino merged 10 commits intovapor:consolekit-5from
fpseverino:update

Conversation

@fpseverino
Copy link
Copy Markdown
Member

  • Fix bug of activity indicator that continued printing after the Task was cancelled
  • withActivityIndicator now shows the "success" or "failure" state automatically based on whether the function throws an error or not
  • Add a title to show next to CustomActivity
  • Improve code coverage

@fpseverino fpseverino requested review from 0xTim and gwynne as code owners July 25, 2025 22:21
Copy link
Copy Markdown
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query around testing

@fpseverino fpseverino requested review from 0xTim, MahdiBM and ptoffy August 19, 2025 17:05
@fpseverino fpseverino merged commit 1b5d770 into vapor:consolekit-5 Aug 23, 2025
15 checks passed
@fpseverino fpseverino deleted the update branch August 23, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants