Skip to content

Remove NIO and use Mutex#208

Merged
fpseverino merged 6 commits intovapor:consolekit-5from
fpseverino:update
May 6, 2025
Merged

Remove NIO and use Mutex#208
fpseverino merged 6 commits intovapor:consolekit-5from
fpseverino:update

Conversation

@fpseverino
Copy link
Copy Markdown
Member

@fpseverino fpseverino commented May 1, 2025

  • Update package to Swift 6.0, macOS v15
  • Remove dependency on SwiftNIO (used only for NIOLockedValueBox, replaced by Mutex)
  • Add Android CI

@fpseverino fpseverino requested review from 0xTim and gwynne as code owners May 1, 2025 21:00
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.61%. Comparing base (b7854a8) to head (b2300b4).
Report is 1 commits behind head on consolekit-5.

Files with missing lines Patch % Lines
Sources/ConsoleKitCommands/Signatures/Option.swift 66.66% 2 Missing ⚠️
...onsoleKitTerminal/Activity/ActivityIndicator.swift 66.66% 2 Missing ⚠️
...urces/ConsoleKitCommands/Signatures/Argument.swift 66.66% 1 Missing ⚠️
Sources/ConsoleKitCommands/Signatures/Flag.swift 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           consolekit-5     #208      +/-   ##
================================================
+ Coverage         45.75%   46.61%   +0.86%     
================================================
  Files                46       46              
  Lines              1906     1860      -46     
================================================
- Hits                872      867       -5     
+ Misses             1034      993      -41
Files with missing lines Coverage Δ
...mands/Async/GenerateAsyncAutocompleteCommand.swift 0.00% <ø> (ø)
...ces/ConsoleKitCommands/Completion/Completion.swift 1.20% <ø> (ø)
...mands/Completion/GenerateAutocompleteCommand.swift 0.00% <ø> (ø)
Sources/ConsoleKitTerminal/Terminal/Terminal.swift 28.76% <100.00%> (+6.89%) ⬆️
...urces/ConsoleKitCommands/Signatures/Argument.swift 80.95% <66.66%> (ø)
Sources/ConsoleKitCommands/Signatures/Flag.swift 76.47% <66.66%> (ø)
Sources/ConsoleKitCommands/Signatures/Option.swift 79.31% <66.66%> (ø)
...onsoleKitTerminal/Activity/ActivityIndicator.swift 38.59% <66.66%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fpseverino fpseverino merged commit 6dc3b99 into vapor:consolekit-5 May 6, 2025
13 checks passed
@fpseverino fpseverino deleted the update branch May 6, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fpseverino @0xTim