Conversation
|
Note: To build on Windows, first one must update |
|
@jeffdav Could you enable Windows CI so we can track this properly? See https://github.com/vapor/jwt-kit/blob/main/.github/workflows/test.yml#L35 |
|
Sure. But we may have to wait for |
|
Yeah I'm not expecting it to pass but we can at least track the errors across the modules and make sure we don't add regressions in new code. It will be a while until NIO ships a windows compatible version |
|
@0xTim #206 BTW when I run It looks like |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 54.18% 54.11% -0.08%
==========================================
Files 103 103
Lines 4603 4609 +6
==========================================
Hits 2494 2494
- Misses 2109 2115 +6
|
e328439 to
bc3eee0
Compare
|
Ah yeah, we're only using NIOConcurrency helpers, not the rest of NIO. Pity we had to pull that in but those fixes should land soon! |
|
SwiftNIO released 2.76.0 with the fixes in it. I believe a rerun of the windows-unit workflow will pass now. |
These changes are now available in 4.15.1
There are three things that cause Terminal to not build on Windows:
isprint()returns anInt32which requires an explicit comparison. Easy fix: just compare against0._getch()returns anInt32, butUnicode.Scalar()takes aUInt32. So we must cast.sizewas Posix-specific. Add a Windows implementation.