Don't animate ActivityIndicator when outputting to a file#202
Merged
0xTim merged 3 commits intovapor:mainfrom Aug 20, 2024
Merged
Don't animate ActivityIndicator when outputting to a file#2020xTim merged 3 commits intovapor:mainfrom
0xTim merged 3 commits intovapor:mainfrom
Conversation
Contributor
Author
Contributor
Author
0xTim
approved these changes
Aug 20, 2024
Member
0xTim
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay, looks good to me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 56.32% 54.26% -2.07%
==========================================
Files 101 103 +2
Lines 4495 4515 +20
==========================================
- Hits 2532 2450 -82
- Misses 1963 2065 +102
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.15.0
Long running loading/progress indicators create a lot of noisy output when an executable is outputting to Xcode's console, being captured to a file, or a piped to another command. e.g. #141
This PR skips writing the animated output of an
ActivityIndicatorif the console will not handle it well.