Elide main queue check in Linux readpassphrase() implementation#185
Merged
Elide main queue check in Linux readpassphrase() implementation#185
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 49.01% 48.91% -0.11%
==========================================
Files 45 45
Lines 1887 1887
==========================================
- Hits 925 923 -2
- Misses 962 964 +2
|
0xTim
requested changes
Aug 29, 2023
0xTim
approved these changes
Aug 29, 2023
|
These changes are now available in 4.10.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an
asyncworld, the check for running on the main queue inlinux_readpassphrase()is hopelessly wrong. Since it's a violation of the API contract to call this method from multiple threads, we just remove the bad assertion and let misuse fail out the same way the "real" API would.Fixes #184.