fs: fix GenerateIndexPages when DirFS or embed.FS is used#1778
Merged
erikdubbelboer merged 1 commit intovalyala:masterfrom May 18, 2024
Merged
fs: fix GenerateIndexPages when DirFS or embed.FS is used#1778erikdubbelboer merged 1 commit intovalyala:masterfrom
erikdubbelboer merged 1 commit intovalyala:masterfrom
Conversation
Collaborator
|
Thanks! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current implementation of Fasthttp FS, GenerateIndexPages doesn't work properly with DirFS or embed.FS because of
fs.ValidPathfunction.When you open
""path using with DirFS it returnsinvalid path error. When using embed.FS, it returnsfile does not existerror.So, if the path is
""both cases need to covered properly.Note: I ain't also sure this is a good solution. Perhaps need smarter solution to cover more edge cases.