Multi-database support in cluster mode#242
Merged
Merged
Conversation
- Updated documentation to reflect multi-database support in Valkey Cluster. - Removed outdated restrictions on `SELECT` and database-related commands. - Clarified that `MIGRATE`, `COUNTKEYSINSLOT`, and `GETKEYSINSLOT` operate within the selected database. - Clarified that `SWAPDB` is disabled in cluster mode to prevent shard inconsistencies. Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
Member
Author
|
Depends on valkey-io/valkey#1671 |
madolson
reviewed
May 6, 2025
madolson
left a comment
Member
There was a problem hiding this comment.
Mostly looks good, minor suggestions.
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
zuiderkwast
reviewed
May 23, 2025
zuiderkwast
reviewed
May 23, 2025
Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
zuiderkwast
approved these changes
May 26, 2025
This reverts commit 43f16ec. Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECTand database-related commands.MIGRATE,COUNTKEYSINSLOT, andGETKEYSINSLOToperate within the selected database.SWAPDBis disabled in cluster mode to prevent shard inconsistencies.