Skip to content

Fix typo option name in repl-ping-replica-period comment in valkey.conf#3937

Merged
hpatro merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:cleanup
Jun 8, 2026
Merged

Fix typo option name in repl-ping-replica-period comment in valkey.conf#3937
hpatro merged 1 commit into
valkey-io:unstablefrom
enjoy-binbin:cleanup

Conversation

@enjoy-binbin

@enjoy-binbin enjoy-binbin commented Jun 8, 2026

Copy link
Copy Markdown
Member

Minor cleanup, now it is the real option name.

@enjoy-binbin
Fix typo option name in repl-ping-replica-period comment in valkey.conf
009d34a 
Minor cleanup, now it is the real option name.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88e2ec3e-9bf5-4afd-a23e-b284af52ef58

📥 Commits

Reviewing files that changed from the base of the PR and between b0137ef and 009d34a.

📒 Files selected for processing (1)
  • valkey.conf
📝 Walkthrough

Walkthrough

A single comment in the replication configuration section is updated to reference the hyphenated option name repl-ping-replica-period instead of an underscored variant, aligning the documentation with the actual configuration option naming convention.

Changes

Configuration Documentation

Layer / File(s) Summary
Configuration comment correction
valkey.conf		 Line 849 comment updated to reference repl-ping-replica-period (hyphenated) instead of repl_ping_replica_period (underscored).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately describes the main change: fixing a typo in a comment to use the correct hyphenated option name.
Description check ✅ Passed The description is related to the changeset, describing it as a minor cleanup that corrects the option name to match the real option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.95%. Comparing base (b0137ef) to head (009d34a).

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #3937      +/-   ##
============================================
+ Coverage     76.69%   76.95%   +0.25%     
============================================
  Files           162      162              
  Lines         80731    80731              
============================================
+ Hits          61917    62126     +209     
+ Misses        18814    18605     -209

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hpatro hpatro merged commit f7b236d into valkey-io:unstable Jun 8, 2026
64 checks passed
@enjoy-binbin enjoy-binbin deleted the cleanup branch June 9, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hpatro hpatro hpatro approved these changes

Assignees

@enjoy-binbin enjoy-binbin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enjoy-binbin @hpatro