Skip to content

Remove test failure detector workflow#3919

Merged
sarthakaggarwal97 merged 7 commits into
valkey-io:unstablefrom
BChan-0:unstable
Jun 23, 2026
Merged

Remove test failure detector workflow#3919
sarthakaggarwal97 merged 7 commits into
valkey-io:unstablefrom
BChan-0:unstable

Conversation

@BChan-0

@BChan-0 BChan-0 commented Jun 4, 2026 •
edited by sarthakaggarwal97
Loading

Copy link
Copy Markdown
Contributor

Purpose

This workflow was originally introduced in PR #3358, where we detect the failures in our scheduled daily runs and create / update github issues.

We want to do more things with AI with respect to tests failures. It could include potentially finding the root cause, any PR that broke the tests, some helpful dashboard to track daily tests, maybe some analysis or possible fix as well.
To achieve that, we are moving this issue management out of this repository and into valkey-ci-agent.

The Daily workflow in this repository still records per-job test failures, consolidates them into all-test-failures.json, and uploads the all-test-failures artifact. The workflow being removed here was only responsible for consuming that artifact and creating or updating GitHub issues.

Changes

Remove .github/workflows/test-failure-detector.yml.

Issue creation and updates are now handled by the Test Failure Detector workflow in valkey-ci-agent through this PR #24.

Notes

This should be merged together with the corresponding valkey-ci-agent change so scheduled test-failure detection continues without a gap.

@BChan-0
Removing .github/workflows/test-failure-detector.yml (Migrating tool …
436da8f 
…to valkey-ci-agent repo)

Migration of PR 3358 test failure detection code (read daily CI, analyze failure artifact, post/update issue) to valkey-io/valkey-ci-agent

Signed-off-by: Bonnie Chan <bonchan35@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This pull request removes the .github/workflows/test-failure-detector.yml workflow, which was a GitHub Actions automation that downloaded consolidated test failure artifacts, merged results, and created or updated labeled GitHub issues with CI links and environment details.

Changes

Cohort / File(s) Summary
Workflow Deletion
.github/workflows/test-failure-detector.yml		 Removed the entire test-failure-detector workflow (273 lines deleted). This automation had downloaded all-test-failures artifacts, merged failure data, and created/updated GitHub issues to track CI test failures across environments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately and concisely describes the main change: removal of the test-failure-detector workflow file.
Description check ✅ Passed The pull request description clearly explains the purpose, changes, and context of removing the test-failure-detector.yml workflow as part of migrating functionality to valkey-ci-agent.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sarthakaggarwal97 sarthakaggarwal97 requested a review from hpatro June 4, 2026 19:55
@sarthakaggarwal97

sarthakaggarwal97 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@hpatro sharing some more context. We want to do more things with AI with respect to flaky tests / tests failures. It could include potentially finding the root cause, any PR that broke the tests, some helpful dashboard to track daily tests, maybe some analysis or possible fix as well. So we want to move this detector to valkey-ci-agent where it will be easier to manage this workflow.

sarthakaggarwal97
sarthakaggarwal97 approved these changes Jun 4, 2026
View reviewed changes

@sarthakaggarwal97 sarthakaggarwal97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BChan-0 for a quick turnaround on this one.

@asagege

asagege commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Taking a look

@hanxizh9910 hanxizh9910 self-requested a review June 4, 2026 20:40
hanxizh9910
hanxizh9910 approved these changes Jun 4, 2026
View reviewed changes

@hanxizh9910 hanxizh9910 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since the workflow is triggered via workflow_run and not referenced by any other workflow, this is the only file we need to remove for the migration.

@asagege

asagege commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

LGTM, needs to look at 2 failing checks, and wait until valkey-io/valkey-ci-agent#24 got approved, and then we can merge both PRs

@sarthakaggarwal97 sarthakaggarwal97 changed the title Removal of test-failure-detector.yml (Migrating tool to valkey-ci-agent repo) Remove test failure detector workflow Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.76%. Comparing base (436dcae) to head (c52bb5d).
⚠️ Report is 3 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #3919   +/-   ##
=========================================
  Coverage     76.75%   76.76%           
=========================================
  Files           162      162           
  Lines         81017    81017           
=========================================
+ Hits          62187    62194    +7     
+ Misses        18830    18823    -7

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sarthakaggarwal97
sarthakaggarwal97 approved these changes Jun 23, 2026
View reviewed changes

@sarthakaggarwal97 sarthakaggarwal97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Since the PR in valkey-ci-agent is ready, I will merge this.

@sarthakaggarwal97 sarthakaggarwal97 merged commit ebe6215 into valkey-io:unstable Jun 23, 2026
64 checks passed
@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarthakaggarwal97 sarthakaggarwal97 sarthakaggarwal97 approved these changes
@hpatro hpatro Awaiting requested review from hpatro
+1 more reviewer
@hanxizh9910 hanxizh9910 hanxizh9910 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BChan-0 BChan-0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BChan-0 @sarthakaggarwal97 @asagege @hanxizh9910