Document database-level ACL rules in valkey.conf and acl.c#3808
Conversation
The db=, alldbs and resetdbs rules introduced in valkey-io#2309 were missing from the ACL self-documenting block in valkey.conf. Also update the `reset` description to include alldbs and sanitize-payload, and add ERANGE to the documented errno values. Signed-off-by: Binbin <binloveplay1314@qq.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates ACL documentation across ChangesACL Documentation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3808 +/- ##
============================================
+ Coverage 76.72% 76.94% +0.21%
============================================
Files 162 162
Lines 80710 80710
============================================
+ Hits 61927 62104 +177
+ Misses 18783 18606 -177
🚀 New features to boost your workflow:
|
dvkashapov
left a comment
There was a problem hiding this comment.
LGTM, thank you! One minor suggestion on wording, took it from our docs.
Co-authored-by: Daniil Kashapov <daniil.kashapov.ykt@gmail.com> Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
There was a problem hiding this comment.
Thanks,
just notice, santitize-payload will be removed in #3721. We need to keep track and remember to update accordingly when rebasing/merging them.
The db=, alldbs and resetdbs rules introduced in #2309 were
missing from the ACL self-documenting block in valkey.conf.
Also update the
resetdescription to include alldbs andsanitize-payload, and add ERANGE to the documented errno values.