Change default pidfile from redis.pid to valkey.pid#378
Merged
zuiderkwast merged 1 commit intoApr 30, 2024
Conversation
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #378 +/- ##
=========================================
Coverage 68.40% 68.40%
=========================================
Files 108 108
Lines 61562 61562
=========================================
Hits 42109 42109
Misses 19453 19453 |
Contributor
Author
|
@zuiderkwast, Can you check this PR when you get some time? |
zuiderkwast
approved these changes
Apr 30, 2024
zuiderkwast
left a comment
Contributor
There was a problem hiding this comment.
Good!
pidfile /var/run/valkey_6379.pid was already written in the template config file valkey.conf. This is not a default. It is a value you get if you use the template config as is. The default is what you get when you start without a config.
This was referenced Jun 11, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default value for the
pidfileconfig.The template config file
valkey.confalready containspidfile /var/run/valkey_6379.pid. This is not a default. The default is what you get when you start valkey without config.Tests suites config pidfile changed to valkey accordingly.
Fixes #321