add warning log when certs are expired/not yet valid#3153
Open
YiwenZhang12 wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
This PR adds logging only and is independent of the KPI PR #2913 , but related in purpose. |
added 6 commits
February 4, 2026 10:13
Signed-off-by: Yiwen Zhang <yiwen_zhang@apple.com>
Signed-off-by: Yiwen Zhang <yiwen_zhang@apple.com>
Signed-off-by: Yiwen Zhang <yiwen_zhang@apple.com>
Signed-off-by: Yiwen Zhang <yiwen_zhang@apple.com>
Signed-off-by: Yiwen Zhang <yiwen_zhang@apple.com>
03cef37 to
a52c18f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3153 +/- ##
============================================
+ Coverage 74.72% 74.78% +0.06%
============================================
Files 129 129
Lines 71309 71309
============================================
+ Hits 53284 53330 +46
+ Misses 18025 17979 -46
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Provide clear, consistent logging for expired server owned TLS certs (server/client/CA) at startup/reload and during runtime.
What changed
Added an hourly cron check that scans server‑owned TLS certs (server/client/CA) and logs only expired certs, including the cert serial for identification.
Refined startup/reload validation to emit one specific warning per validity issue (expired / not‑yet‑valid / invalid validity period), removing generic error logs.
CA expiry logging is now capped at three per interval, with a count summary for additional expired CAs.
Example logs:
for multiple ca cert invalid: