Skip to content

[Performance] 20% SET command regression due to IO-Threads redesign cleanup work #3750

Description

@roshkhatri

Describe the bug

Upto 20% SET command regression due to IO-Threads redesign cleanup work #3544

Image

Check HERE
The regression can be seen for IO-thread test cases for SET commands.
This does not cause a regression for 16 byte value, but does for 128 and above

I feel this would be the root cause for the regression.

  • tryOffloadFreeObjToIOThreads: only offload the free of the sds buffer
    (which the I/O thread allocated). The robj itself is main-thread-owned
    and is now freed on the main thread.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions