Skip to content

[BUG] BUILD_RDMA=module and BUILD_TLS=module uses static linking in cli and benchmark #3070

Description

@zuiderkwast

When building Valkey with make BUILD_RDMA=module and/or BUILD_TLS=module, these features are built as modules which are dynamically linked and loaded using MODULE LOAD, but that's only for valkey-server.

valkey-cli and valkey-benchmark are statically linked to the RDMA and/or the OpenSSL libraries, even when building as a module.

Expected behavior

Use dynamic linking also in the cli and benchmark tools.

Alternatively, skip RDMA and TLS support in the cli and benchmark tools when building as a module.

Additional information

Distros want to package valkey without RDMA support and provide RDMA support to Valkey using a module in a separate package.

https://build.opensuse.org/request/show/1326868

@Conan-Kudo

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions