fix: param name of util function (for linter)#270
Merged
Conversation
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 49.38% 49.38%
=======================================
Files 46 46
Lines 8100 8100
=======================================
Hits 4000 4000
Misses 3233 3233
Partials 867 867
Continue to review full report in Codecov by Sentry.
🚨 Try these New Features:
|
mattwelke
pushed a commit
that referenced
this pull request
Nov 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.5](v0.2.4...v0.2.5) (2024-11-24) ### Bug Fixes * param name of util function (for linter) ([#270](#270)) ([b840e3b](b840e3b)) ### Dependency Updates * **deps:** update all non-major dependencies ([#266](#266)) ([43b9fbc](43b9fbc)) * **deps:** update all non-major dependencies ([#269](#269)) ([0e6b008](0e6b008)) * **deps:** update all non-major dependencies to v0.31.3 ([#264](#264)) ([7557f89](7557f89)) * **deps:** update build digest to 5ffe724 ([#263](#263)) ([112c405](112c405)) * **deps:** update build digest to dd09b58 ([#267](#267)) ([57f34c7](57f34c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our Revive linter is disallowing the name
lenfor a parameter. We made this code a while ago, but the linter is raising the issue now. It may be an update to the linter. This changes the parameter name to resolve it.Also applies changes from latest
make reviewableso that the PR can be merged.