fix: slack values generated with incorrect casing#253
Merged
TylerGillson merged 4 commits intomainfrom Nov 8, 2024
Merged
Conversation
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
mattwelke
previously approved these changes
Nov 8, 2024
Contributor
mattwelke
left a comment
There was a problem hiding this comment.
Looks like this just needs a make reviewable.
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 49.16% 49.38% +0.21%
==========================================
Files 46 46
Lines 8089 8100 +11
==========================================
+ Hits 3977 4000 +23
+ Misses 3247 3233 -14
- Partials 865 867 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
added a commit
that referenced
this pull request
Nov 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.3](v0.2.2...v0.2.3) (2024-11-08) ### Bug Fixes * slack values generated with incorrect casing ([#253](#253)) ([e9a78d8](e9a78d8)) ### Other * make reviewable ([#241](#241)) ([9f778ba](9f778ba)) * make reviewable ([#248](#248)) ([0c1c5f8](0c1c5f8)) * update build gsm ([02a4824](02a4824)) * Update README.md ([8cae0a3](8cae0a3)) * Update renovate.json ([#251](#251)) ([0401105](0401105)) ### Dependency Updates * **deps:** update actions/checkout digest to 11bd719 ([#245](#245)) ([de9e4b1](de9e4b1)) * **deps:** update actions/checkout digest to eef6144 ([#236](#236)) ([da46421](da46421)) * **deps:** update actions/setup-go digest to 41dfa10 ([#246](#246)) ([e609b92](e609b92)) * **deps:** update all non-major dependencies ([#252](#252)) ([8c3dce6](8c3dce6)) * **deps:** update anchore/sbom-action action to v0.17.4 ([#240](#240)) ([347cb47](347cb47)) * **deps:** update anchore/sbom-action action to v0.17.6 ([#242](#242)) ([5819cf0](5819cf0)) * **deps:** update golang.org/x/exp digest to 225e2ab ([#234](#234)) ([b34f23c](b34f23c)) * **deps:** update golang.org/x/exp digest to f66d83c ([#239](#239)) ([21f6d92](21f6d92)) * **deps:** update kubernetes packages to v0.31.2 ([#244](#244)) ([ff77688](ff77688)) * **deps:** update module github.com/fsnotify/fsnotify to v1.8.0 ([#249](#249)) ([83f1eed](83f1eed)) * **deps:** update module github.com/vmware/govmomi to v0.44.0 ([#237](#237)) ([bb122f3](bb122f3)) * **deps:** update module github.com/vmware/govmomi to v0.44.1 ([#238](#238)) ([64b877d](64b877d)) * **deps:** update module github.com/vmware/govmomi to v0.45.1 ([#243](#243)) ([d5341a5](d5341a5)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.1 ([#247](#247)) ([d8c689f](d8c689f)) * **deps:** update softprops/action-gh-release digest to e7a8f85 ([#250](#250)) ([31eab3f](31eab3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Ensure proper casing for
channelId.