Conversation
added 2 commits
September 11, 2024 14:34
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
54c4682 to
215f882
Compare
Member
TylerGillson
left a comment
There was a problem hiding this comment.
Since you have fresh context, can you please take a look at #29 and either address it as part of this PR or as a follow up?
Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 53.30% 53.13% -0.18%
==========================================
Files 46 46
Lines 6352 6433 +81
==========================================
+ Hits 3386 3418 +32
- Misses 2117 2151 +34
- Partials 849 864 +15
Continue to review full report in Codecov by Sentry.
|
…ure RBAC and quota rules. Signed-off-by: Matt Welke <matt.welke@spectrocloud.com>
Contributor
Author
Sure, I'll |
TylerGillson
approved these changes
Sep 11, 2024
TylerGillson
added a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2024-09-11) ### Features * support for Azure quota rule ([#224](#224)) ([8e61091](8e61091)) ### Bug Fixes * ignore nil errors in validationResponseOk ([#227](#227)) ([26544e2](26544e2)) ### Refactoring * split ConfigureOrCheckCommand into multiple functions ([#222](#222)) ([466413a](466413a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #225.
Description
Adds support for the rule. Like other rules with potentially repetitive input, users can provide input with a JSON file too.
Extras