refactor: lazy configuration of oci auth and signature verification secrets#168
Merged
ahmad-ibra merged 14 commits intomainfrom Aug 15, 2024
Merged
refactor: lazy configuration of oci auth and signature verification secrets#168ahmad-ibra merged 14 commits intomainfrom
ahmad-ibra merged 14 commits intomainfrom
Conversation
b516ff8 to
9ca49df
Compare
9ca49df to
affc05e
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 53.70% 53.77% +0.07%
==========================================
Files 43 43
Lines 6100 6086 -14
==========================================
- Hits 3276 3273 -3
+ Misses 2003 1994 -9
+ Partials 821 819 -2
Continue to review full report in Codecov by Sentry.
|
…use install to exit before we can apply
ahmad-ibra
commented
Aug 15, 2024
ahmad-ibra
commented
Aug 15, 2024
ahmad-ibra
commented
Aug 15, 2024
TylerGillson
requested changes
Aug 15, 2024
Member
|
Regarding the three out of scope follow ups, I think this PR should address the first one:
And I think the second two are inapplicable once you |
Member
|
Regarding the integration test refactor and this comment:
I don't think that any refactor is called for. The |
fa51f16 to
cb9c274
Compare
cb9c274 to
c9081b9
Compare
8257ee8 to
ed8e43b
Compare
TylerGillson
approved these changes
Aug 15, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2024-08-19) ### Features * add maas plugin ([#160](#160)) ([ab9f21a](ab9f21a)) * allow selecting aws creds from filesystem ([#171](#171)) ([c3a714c](c3a714c)) * allow specifying Azure cloud to connect to ([#170](#170)) ([6a4a704](6a4a704)) * read vCenter privileges from local file or editor ([#152](#152)) ([94ddd90](94ddd90)) * set exit code 2 on validation failure; restore debug log file ([#150](#150)) ([2a3fe4d](2a3fe4d)) * support configuring oci validationType on a rule ([#161](#161)) ([8dfc501](8dfc501)) * support direct oci validation of private registries ([#173](#173)) ([9cfeab9](9cfeab9)) ### Bug Fixes * correct TUI flow for `validator install -o --apply` ([#169](#169)) ([0912f6e](0912f6e)) * export creds for aws and azure direct check ([#167](#167)) ([5d569de](5d569de)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.1 ([#163](#163)) ([416d23c](416d23c)) * **deps:** update github.com/validator-labs/validator-plugin-azure digest to b4687e5 ([#149](#149)) ([e7ab9a6](e7ab9a6)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to a93cb70 ([#147](#147)) ([79304b9](79304b9)) * **deps:** update module github.com/vmware/govmomi to v0.40.0 ([#162](#162)) ([acf4a25](acf4a25)) ### Refactoring * lazy configuration of oci auth and signature verification secrets ([#168](#168)) ([cc2c056](cc2c056)) * remove explicit TypeMetas; use vapi constants ([#154](#154)) ([28b321c](28b321c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we were required to configure auth and signature verification secrets before we even add any oci rules. Now we can lazily create the auth and signature verification secrets as we create the rules. ie no need to prep all your pubkeys and creds before you even set up your rule.
This PR also does the following:
--reconfigureing oci rules. Previously rule updates werent getting properly persistedRefactors integration testsIt ensures that we actually run thevalidator install --applytests which should really bump our code coverage up by a lotCovers the case of provisioning a new kind cluster or using a pre-provisioned clustervalidator install --applywas no longer working due to the kind cluster not starting upContext on the integration test refactorThe reason for the big changes in the integration tests were that i had noticed the oci plugin integration tests were passing without me updating any of the prompts when they clearly shouldnt pass. This got me down a rabbit hole of investigating why they were passing and eventually making the necessary changes. While doing this, it uncovered a few other issues. For the sake of not adding even more to this PR, i've marked someTODOsaround things that need to be fixed. IMO we should fix them in follow ups shortly after this PR is eventually merged.Out of scope follow up work
validator rules checkon a private oci registry