Skip to content

Update for 0.211.7#710

Merged
nxPublic merged 2 commits intovalheimPlus:developmentfrom
healiha:development
Oct 12, 2022
Merged

Update for 0.211.7#710
nxPublic merged 2 commits intovalheimPlus:developmentfrom
healiha:development

Conversation

@healiha
Copy link
Copy Markdown
Contributor

@healiha healiha commented Sep 29, 2022

Update code base and increase version number for new release.

@healiha healiha requested a review from nxPublic September 29, 2022 15:56
This was referenced Oct 3, 2022
Closed
Closed
increddibelly
increddibelly previously approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@increddibelly increddibelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion. LGTM

Comment thread ValheimPlus/GameClasses/ZNet.cs Outdated
smietanka
smietanka previously approved these changes Oct 8, 2022
View reviewed changes
@mikael0hlsson
Copy link
Copy Markdown

mikael0hlsson commented Oct 8, 2022

Lets get it out :)

@healiha
Copy link
Copy Markdown
Contributor Author

healiha commented Oct 8, 2022

As much as I appreciate people approving my PR, only @nxPublic can merge it

He should be back today, you can expect an official release of 0.9.9.9 soon.

@healiha @increddibelly
Update ValheimPlus/GameClasses/ZNet.cs
0291a16 
Co-authored-by: Joost Boomkamp <3604126+increddibelly@users.noreply.github.com>
@healiha healiha dismissed stale reviews from smietanka and increddibelly via 0291a16 October 8, 2022 14:18
@rodpedrassi
Copy link
Copy Markdown

rodpedrassi commented Oct 8, 2022

there is any way to contact @nxPublic ?

@Shigbeard
Copy link
Copy Markdown

Shigbeard commented Oct 8, 2022

there is any way to contact @nxPublic ?

He's currently unable to merge the pull request due to his IRL commitments. There's a relevant announcement about this in the Discord dating back to the 29th of September. All we can do is be patient.

@increddibelly
Copy link
Copy Markdown
Contributor

increddibelly commented Oct 12, 2022

we're on 211.9 now, I haven't checked yet if this breaks anything.
https://valheim.com/news/patch-0-211-9/

@ghost
Copy link
Copy Markdown

ghost commented Oct 12, 2022

Why can't @nxPublic authorize someone else to merge, if he is unable to attend to this project?

nxPublic
nxPublic approved these changes Oct 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nxPublic nxPublic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you @healiha

Sorry at everyone having waited so long for me to merge everything.
I've already made steps to make sure it won't happen again together with the rest of the people actively curating the project!

@Shigbeard
Copy link
Copy Markdown

Shigbeard commented Oct 12, 2022

... was just about to comment about how Healiha told me there would be an internal discussion to deal with scenarios like this moving forward.... lmao

Cheers for this nx!

@nxPublic nxPublic merged commit 6d09579 into valheimPlus:development Oct 12, 2022
@Shigbeard
Copy link
Copy Markdown

Shigbeard commented Oct 12, 2022

we're on 211.9 now, I haven't checked yet if this breaks anything.
https://valheim.com/news/patch-0-211-9/

this patch still works with 211.9

@Shigbeard Shigbeard mentioned this pull request Oct 12, 2022
Closed
4 tasks
@ghost
Copy link
Copy Markdown

ghost commented Oct 12, 2022

Thanks @nxPublic for merging - is someone gonna create a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nxPublic nxPublic nxPublic approved these changes

+2 more reviewers

@increddibelly increddibelly increddibelly left review comments

@smietanka smietanka smietanka left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@healiha @mikael0hlsson @rodpedrassi @Shigbeard @increddibelly @smietanka @nxPublic