Removed version debug logs#678
Merged
nxPublic merged 1 commit intovalheimPlus:developmentfrom Feb 15, 2022
Merged
Conversation
nxPublic
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug logs from the version patch clutter the output log, as no new information is stated. Even worse, when other mods are also changing the version string after V+ the logs are lying.
When a version check occurs, vanilla logs this always with
ZLog.Log("VERSION check their:" + text + " mine:" + Version.GetVersionString());. The additional logs are especially a problem when other mods ask the game version, resulting in even more logs