This repository was archived by the owner on Mar 1, 2021. It is now read-only.
Update API key placeholders and tutorial for mapzen.js#177
Merged
Conversation
9 tasks
Collaborator
Author
|
This is ready for review and merge now. There are a few issues with the code blocks not updating to switch API keys, but we should go ahead and review and merge this PR to complete the work on the content side of this project. Expected behavior: When you are not signed in, or are signed in but have no API keys, you will continue to see placeholder text ("your-mapzen-api-key")...more enhancements coming to the placeholder text. https://dev.mapzen.com/documentation/mobility/turn-by-turn/add-routing-to-a-map/ Remaining issues are with the code and are being tracked in mapzen/documentation#312. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of mapzen/documentation#310
This updates the tutorial to remove text that tells people what "your-mapzen-api-key" means, and this is no longer needed with API key swapping.
While I was in there...this also updates the tutorial to use mapzen.js, which simplifies the references to CSS and JS files.