dont check restrictions when there are none#2539
Closed
kevinkreiser wants to merge 3 commits intomasterfrom
Closed
dont check restrictions when there are none#2539kevinkreiser wants to merge 3 commits intomasterfrom
kevinkreiser wants to merge 3 commits intomasterfrom
Conversation
dnesbitt61
previously approved these changes
Aug 18, 2020
Member
dnesbitt61
left a comment
There was a problem hiding this comment.
2 small things:
restriction spelled wrong in the comment.
perhaps change auto_type to mode or travel_mode as auto_type makes me think this only impacts automobiles.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a slightly performance improvement to avoid looking at restriction information when we already know there shouldnt be any for your mode of travel. this has been a "bug" for a long time.
the previous code said, if there are any restrictions on this edge lets check for which ones match our mode. but we can shortcut this and quickly say, using the mask, whether or not there should be any restrictions for the mode we are interested it. this should mildly benefit routes on data that has a lot of restructions for modes of travel that arent subject to those restrictions