There are a few functions in the odin/signs.h that are returning a std::string by const value, eg:
const std::string GetGuideBranchString(uint32_t max_count = 0,
bool limit_by_consecutive_count = false,
const std::string& delim = "/",
const VerbalTextFormatter* verbal_formatter = nullptr) const;Returning by const-value prevents rvalue moves (C++11 and higher), which can degrade performance, and offer almost no benefit.
We should remove const from all functions returning by value.
There are a few functions in the
odin/signs.hthat are returning astd::stringbyconstvalue, eg:Returning by const-value prevents rvalue moves (C++11 and higher), which can degrade performance, and offer almost no benefit.
We should remove
constfrom all functions returning by value.