Skip to content

fix: avoid cp39-musllinux_aarch64 timeout#2434

Merged
maartenbreddels merged 8 commits intovaexio:masterfrom
ddelange:patch-3
Sep 18, 2024
Merged

fix: avoid cp39-musllinux_aarch64 timeout#2434
maartenbreddels merged 8 commits intovaexio:masterfrom
ddelange:patch-3

Conversation

@ddelange
Copy link
Contributor

@ddelange ddelange commented Sep 13, 2024

Supersedes #2433, tried bumping build system to numpy v2 but that is failing (and required for python 3.13 ref scipy/oldest-supported-numpy#86)

on master there is only one failing wheel build: https://github.com/vaexio/vaex/actions/runs/10835977160/job/30068700570

due to oldest-supported-numpy selecting a version of numpy for which no wheels are available. building numpy from source under QEMU takes forever, so we're hitting the builtin github actions 6 hour timeout (which can't be increased)

@ddelange ddelange mentioned this pull request Sep 13, 2024
@ddelange
Copy link
Contributor Author

@maartenbreddels CI now finishes consistently within 2 hours

@ddelange
Copy link
Contributor Author

opened scipy/oldest-supported-numpy#85

@ddelange
Copy link
Contributor Author

ddelange commented Sep 13, 2024

according to oldest-supported-numpy deprecation notice, we can require numpy~=1.25 (or numpy v2) in the build-system, and the compiled vaex should become backwards compatible.

@ddelange
Copy link
Contributor Author

Closing in favour of #2435

@ddelange ddelange closed this Sep 13, 2024
@ddelange
Copy link
Contributor Author

ddelange commented Sep 13, 2024

Ah no actually, reopening. this PR is needed regardless of #2435, due to the cp38-musllinux_aarch64 timeout.

or we deprecate py3.8 cc @EwoutH instead of this PR

@ddelange ddelange reopened this Sep 13, 2024
@ddelange ddelange changed the title Skip musllinux_aarch64 wheels fix: avoid cp38-musllinux_aarch64 timeout Sep 13, 2024
* Build using backward-compatible numpy API

* Add deprecated oldest-supported-numpy
@ddelange
Copy link
Contributor Author

ddelange commented Sep 13, 2024

ready for review jongens @maartenbreddels @EwoutH

cleanest way I can think of whilst keeping cp38 support, at least on macos and most of linux

@ddelange ddelange changed the title fix: avoid cp38-musllinux_aarch64 timeout fix: avoid cp39-musllinux_aarch64 timeout Sep 13, 2024
Copy link
Contributor

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(note I’m not an maintainer or formally involved in this project in any way)

@ddelange
Copy link
Contributor Author

@maartenbreddels fingerprinting is broken again.

comparing the uv pip freeze outputs from the last two commits, it's probably due to a dask release:

- dask==2024.8.2
+ dask==2024.9.0

@maartenbreddels
Copy link
Member

it's probably due to a dask release:

Too bad, they were so stable before.

@ddelange
Copy link
Contributor Author

looks like fingerprinting is now random (not a fingerprint anymore). will pin dask<2024.9 instead of the last two commits

@ddelange
Copy link
Contributor Author

@maartenbreddels green again

@maartenbreddels maartenbreddels merged commit 3c27267 into vaexio:master Sep 18, 2024
@maartenbreddels
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants