fix: remove useEffectEvent functions from useEffect dependency arrays#960
Merged
sindresorhus merged 1 commit intoMay 24, 2026
Merged
Conversation
useEffectEvent return values intentionally have an unstable identity (they change every render). Including them in useEffect deps causes the effect to re-run on every render, tearing down and re-subscribing event listeners each time — negating the purpose of useEffectEvent. This was introduced incorrectly in vadimdemedes#941 when the exhaustive-deps lint rule flagged them as missing dependencies. The React linter should recognize useEffectEvent and suppress the warning, but it did not in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleDatafrom theuseEffectdependency array inuseInputhandlePastefrom theuseEffectdependency array inusePasteThese were incorrectly added in #941.
useEffectEventreturn values intentionally have an unstable identity (they change every render), so including them in deps causes the effect to tear down and re-subscribe event listeners on every render — completely negating the purpose ofuseEffectEvent.Per the React docs on
useEffectEvent:The original commit (cfaebbb) that introduced
useEffectEventin these hooks correctly excluded them from the dependency arrays.